feat(node): suggest setting node.flavor if the flavor is not found in mirror by risu729 · Pull Request #8206 · jdx/mise

risu729 · 2026-02-17T11:45:35Z

Resolves #5042

… mirror

gemini-code-assist · 2026-02-17T11:45:48Z

Summary of Changes

Hello @risu729, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the user experience when installing Node.js by providing more informative error messages. Instead of a generic 404, users will now receive actionable advice on how to resolve issues related to missing Node.js versions or specific flavors when using custom mirrors, guiding them towards correct configuration.

Highlights

Enhanced Error Handling for Node.js Installation: Implemented logic to detect 404 Not Found errors when fetching Node.js tarballs from a configured mirror.
Intelligent Flavor Suggestions: When a 404 error occurs and a custom Node.js mirror is in use, the system now attempts to fetch index.json from the mirror to suggest available node.flavor options for the requested version, OS, and architecture.
User Guidance for Flavor Configuration: The error message now includes a helpful suggestion to the user on how to set the node.flavor using mise settings set node.flavor <flavor> if alternative flavors are found.

Changelog

src/plugins/core/node.rs
- Imported DEFAULT_NODE_MIRROR_URL for mirror URL comparison.
- Wrapped fetch_tarball call in error handling to catch reqwest::StatusCode::NOT_FOUND.
- Added a new asynchronous function suggest_available_flavors to dynamically recommend Node.js flavors based on mirror content.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds a helpful feature to suggest available Node.js flavors when a specific version is not found on a custom mirror. The implementation correctly intercepts 404 errors and queries the mirror's index.json to provide suggestions. However, there is a compilation error in the new suggest_available_flavors function that needs to be addressed.

gemini-code-assist · 2026-02-17T11:48:10Z

src/plugins/core/node.rs

+        let versions: Vec<NodeVersion> = HTTP_FETCH
+            .json(base.join("index.json")?)
+            .await
+            .unwrap_or_default();


This call to .unwrap_or_default() on a Result will not compile because Result does not implement this method. The likely intent is to default to an empty Vec<NodeVersion> if the HTTP request fails. You can achieve this by first converting the Result to an Option with .ok().

Suggested change

.unwrap_or_default();

.ok().unwrap_or_default();

Copilot

Pull request overview

This PR adds a helpful suggestion feature to the Node.js plugin that guides users when a node version cannot be found in a custom mirror. When installing Node.js from a non-default mirror and encountering a 404 error, the tool now fetches the mirror's index.json to check if alternative "flavors" (like musl vs glibc) are available for the requested version and suggests setting the appropriate flavor.

Changes:

Enhanced error handling in install_compiling to detect 404 errors and suggest available flavors
Added suggest_available_flavors method to query mirror's index.json and provide helpful suggestions about available node flavors
Import of DEFAULT_NODE_MIRROR_URL constant to identify when custom mirrors are being used

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-17T11:50:38Z

src/plugins/core/node.rs

+            if let Some(reqwest_err) = err.root_cause().downcast_ref::<reqwest::Error>()
+                && reqwest_err.status() == Some(reqwest::StatusCode::NOT_FOUND)
+                    && let Ok(Some(msg)) = self
+                        .suggest_available_flavors(&opts.version, &Settings::get())
+                        .await
+                    {
+                        return Err(eyre::eyre!("{err}\n{msg}"));
+                    }


The error handling pattern here differs from the established pattern in the codebase. In fetch_binary (line 69) and verify_with_gpg (line 292), the code uses http::error_code(&e) to check for 404 errors. This new code uses err.root_cause().downcast_ref::<reqwest::Error>() and checks the status directly. Consider using the existing http::error_code helper function for consistency with the rest of the codebase.

Suggested change

if let Some(reqwest_err) = err.root_cause().downcast_ref::<reqwest::Error>()

&& reqwest_err.status() == Some(reqwest::StatusCode::NOT_FOUND)

&& let Ok(Some(msg)) = self

.suggest_available_flavors(&opts.version, &Settings::get())

.await

{

return Err(eyre::eyre!("{err}\n{msg}"));

}

if crate::http::error_code(&err) == Some(404) {

if let Ok(Some(msg)) = self

.suggest_available_flavors(&opts.version, &Settings::get())

.await

{

return Err(eyre::eyre!("{err}\n{msg}"));

Copilot · 2026-02-17T11:50:39Z

src/plugins/core/node.rs

+            .await
+            .unwrap_or_default();
+
+        if let Some(version) = versions.iter().find(|nv| {


The HTTP request error from fetching index.json is silently ignored with unwrap_or_default(). If the mirror is misconfigured or the network request fails for any reason (timeout, connection error, invalid JSON, etc.), this will silently return an empty vector and the function will return Ok(None), providing no helpful feedback to the user about why the suggestion system didn't work. Consider logging a warning or debug message when the fetch fails so users can troubleshoot mirror configuration issues.

Suggested change

.await

.unwrap_or_default();

if let Some(version) = versions.iter().find(|nv| {

let versions: Vec<NodeVersion> = match HTTP_FETCH

.json(base.join("index.json")?)

.await

{

Ok(versions) => versions,

Err(err) => {

eprintln!(

"Warning: failed to fetch Node mirror index.json from {}: {err}",

base

);

Vec::new()

}

};

Copilot · 2026-02-17T11:50:39Z

src/plugins/core/node.rs

+        if let Some(version) = versions.iter().find(|nv| {
+            nv.version == format!("v{v}") || nv.version == v || nv.version == format!("v{v}.")
+        }) {
+            let os = os();


The version comparison logic includes format!("v{v}.") which appears to be checking for a version string ending with a period. This seems incorrect as version strings typically don't end with a period. This condition would match versions like "v20.0.0." which is unlikely to be a valid version format. Consider removing this comparison or clarifying the intended behavior if there's a specific use case for versions ending with periods.

Suggested change

let os = os();

nv.version == format!("v{v}") || nv.version == v

Copilot · 2026-02-17T11:50:40Z

src/plugins/core/node.rs

+        // If using default mirror, we don't need to suggest anything as it's likely a real 404
+        if base.to_string() == DEFAULT_NODE_MIRROR_URL {
+            return Ok(None);
+        }


The URL comparison uses string comparison which may not be reliable for URLs. The URL base.to_string() could have variations like trailing slashes or different representations that would still be semantically equivalent. Consider using URL comparison directly or normalizing both URLs before comparison. For example, if one has a trailing slash and the other doesn't, they would be considered different even though they represent the same resource.

@joaommartins

### 🚀 Features - **(mcp)** add run_task tool for executing mise tasks by @joaommartins in [#8179](#8179) - **(node)** suggest setting node.flavor if the flavor is not found in mirror by @risu729 in [#8206](#8206) ### 🐛 Bug Fixes - **(java)** sort order for shorthand versions by @roele in [#8197](#8197) - **(node)** migrate env vars to settings by @risu729 in [#8200](#8200) - **(registry)** apply overrides in shims by @risu729 in [#8199](#8199) - migrate MISE_CARGO_BINSTALL_ONLY to settings by @risu729 in [#8202](#8202) ### 📚 Documentation - **(doctor)** fix subcommand in an example by @risu729 in [#8198](#8198) ### 📦 Registry - add github backend for typst by @3w36zj6 in [#8210](#8210) ### Chore - **(test)** disable flaky Forgejo e2e test by @jdx in [#8211](#8211)

… mirror (jdx#8206) Resolves jdx#5042 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

feat(node): suggest setting node.flavor if the flavor is not found in…

38d989e

… mirror

Copilot AI review requested due to automatic review settings February 17, 2026 11:45

Copilot started reviewing on behalf of risu729 February 17, 2026 11:46 View session

gemini-code-assist bot reviewed Feb 17, 2026

View reviewed changes

[autofix.ci] apply automated fixes

82289d4

Copilot AI reviewed Feb 17, 2026

View reviewed changes

[autofix.ci] apply automated fixes (attempt 2/3)

589d236

jdx merged commit 66497f9 into jdx:main Feb 17, 2026
33 checks passed

mise-en-dev mentioned this pull request Feb 17, 2026

chore: release 2026.2.16 #8204

Merged

risu729 deleted the suggest-node-mirror-flavours branch February 17, 2026 12:36

BrewTestBot mentioned this pull request Feb 18, 2026

mise 2026.2.16 Homebrew/homebrew-core#268166

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(node): suggest setting node.flavor if the flavor is not found in mirror#8206

feat(node): suggest setting node.flavor if the flavor is not found in mirror#8206
jdx merged 3 commits intojdx:mainfrom
risu729:suggest-node-mirror-flavours

risu729 commented Feb 17, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 17, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-            .await
-            .unwrap_or_default();
-        if let Some(version) = versions.iter().find(|nv| {
+        let versions: Vec<NodeVersion> = match HTTP_FETCH
+            .json(base.join("index.json")?)
+            .await
+        {
+            Ok(versions) => versions,
+            Err(err) => {
+                eprintln!(
+                    "Warning: failed to fetch Node mirror index.json from {}: {err}",
+                    base
+                );
+                Vec::new()
+            }
+        };

	let os = os();
	nv.version == format!("v{v}") \|\| nv.version == v

Uh oh!

Comments

Conversation

risu729 commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 17, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

risu729 commented Feb 17, 2026 •

edited

Loading