fix(github): show attestation verification success in progress output by jdx · Pull Request #8230 · jdx/mise

jdx · 2026-02-18T02:25:04Z

Summary

Show "✓ GitHub attestations verified" in the github backend progress after successful verification, matching aqua backend behavior

Closes #8217

Test plan

Install a tool via github backend that has attestations (e.g. uv) and confirm "✓ GitHub attestations verified" appears in progress

🤖 Generated with Claude Code

gemini-code-assist · 2026-02-18T02:25:15Z

Summary of Changes

Hello @jdx, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by providing clearer feedback during GitHub attestation verification and reducing log noise. It introduces a visible confirmation message for successful attestation verification and intelligently filters out verbose INFO messages from third-party libraries in standard output, ensuring a cleaner and more focused user interface.

Highlights

GitHub Attestation Verification Output: The pull request now displays "✓ GitHub attestations verified" in the progress output when GitHub attestations are successfully verified, aligning with the behavior of the aqua backend.
Suppress External Crate INFO Logs: INFO level messages from external crates, such as sigstore key-parsing diagnostics, are now suppressed in non-verbose mode to prevent confusing users with internal implementation details.

Changelog

src/backend/github.rs
- Added a progress message to indicate successful GitHub attestation verification.
src/logger.rs
- Implemented conditional logic to suppress INFO level logs from external crates when not in debug mode.

Activity

No human activity has occurred on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces two user-facing improvements. First, it adds a success message "✓ GitHub attestations verified" when GitHub attestations are successfully verified, which enhances the user experience by providing clear feedback. Second, it suppresses INFO level log messages from external crates (like sigstore) in non-verbose mode, reducing noise and preventing user confusion from internal diagnostics. The changes are well-implemented and align with the PR's goals. I have one minor suggestion to improve the clarity of the logging condition.

gemini-code-assist · 2026-02-18T02:26:29Z

src/logger.rs

+        let will_log_term = if record.level() == Level::Info
+            && term_level < LevelFilter::Debug
+            && !record.target().starts_with("mise")
+        {
+            false
+        } else {
+            record.level() <= term_level
+        };


The condition term_level < LevelFilter::Debug is correct for checking if we're in non-verbose mode. However, since this logic specifically targets INFO level logs, it only has a practical effect when term_level is Info. For lower levels like Warn or Error, INFO logs would be filtered out by the else branch anyway.

For improved clarity and to be more explicit about the exact condition under which this logic applies, you could use term_level == LevelFilter::Info or term_level <= LevelFilter::Info. This makes it clearer that we're only modifying behavior for the Info log level.

This is a minor suggestion for readability.

Suggested change

let will_log_term = if record.level() == Level::Info

&& term_level < LevelFilter::Debug

&& !record.target().starts_with("mise")

{

false

} else {

record.level() <= term_level

};

let will_log_term = if record.level() == Level::Info

&& term_level <= LevelFilter::Info

&& !record.target().starts_with("mise")

{

false

} else {

record.level() <= term_level

};

Copilot

Pull request overview

This PR improves the user experience when installing tools with GitHub attestations by (1) displaying a success message after verification matching the aqua backend's behavior, and (2) suppressing confusing internal diagnostic INFO messages from external crates like sigstore in non-verbose mode.

Changes:

Added success message "✓ GitHub attestations verified" to github backend matching aqua backend behavior
Filtered INFO-level logs from external crates (non-mise modules) in terminal output when not in debug/verbose mode

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/backend/github.rs	Added success message display after GitHub attestation verification
src/logger.rs	Added filter to suppress external crate INFO messages in non-verbose terminal output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is ON, but a Cloud Agent failed to start.}

src/logger.rs

Show "✓ GitHub attestations verified" in the github backend progress after successful verification, matching aqua backend behavior. Closes #8217 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-02-18T02:54:32Z

Hyperfine Performance

`mise x -- echo`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.2.15 x -- echo`	23.7 ± 0.4	23.0	27.9	1.00
`mise x -- echo`	23.9 ± 0.3	23.3	25.6	1.01 ± 0.02

`mise env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.2.15 env`	23.4 ± 0.7	22.7	30.0	1.00
`mise env`	23.5 ± 0.3	22.8	25.9	1.00 ± 0.03

`mise hook-env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.2.15 hook-env`	24.0 ± 0.3	23.2	25.5	1.00
`mise hook-env`	24.1 ± 0.3	23.5	25.6	1.01 ± 0.02

`mise ls`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2026.2.15 ls`	21.3 ± 0.3	20.7	23.2	1.00
`mise ls`	21.6 ± 0.3	20.9	23.7	1.01 ± 0.02

`xtasks/test/perf`

Command	mise-2026.2.15	mise	Variance
install (cached)	132ms	131ms	+0%
ls (cached)	81ms	80ms	+1%
bin-paths (cached)	86ms	86ms	+0%
task-ls (cached)	815ms	814ms	+0%

Copilot AI review requested due to automatic review settings February 18, 2026 02:25

Copilot started reviewing on behalf of jdx February 18, 2026 02:25 View session

gemini-code-assist bot reviewed Feb 18, 2026

View reviewed changes

Copilot AI reviewed Feb 18, 2026

View reviewed changes

cursor bot reviewed Feb 18, 2026

View reviewed changes

src/logger.rs Outdated Show resolved Hide resolved

fix(github): show attestation verification success in progress output

2dc2802

Show "✓ GitHub attestations verified" in the github backend progress after successful verification, matching aqua backend behavior. Closes #8217 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jdx force-pushed the fix/attestation-output branch from 1896c32 to 2dc2802 Compare February 18, 2026 02:37

jdx changed the title ~~fix(github): improve attestation verification output~~ fix(github): show attestation verification success in progress output Feb 18, 2026

jdx merged commit 0bf0e85 into main Feb 18, 2026
36 checks passed

jdx deleted the fix/attestation-output branch February 18, 2026 02:57

BrewTestBot mentioned this pull request Feb 18, 2026

mise 2026.2.16 Homebrew/homebrew-core#268166

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(github): show attestation verification success in progress output#8230

fix(github): show attestation verification success in progress output#8230
jdx merged 1 commit intomainfrom
fix/attestation-output

jdx commented Feb 18, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 18, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Comments

Conversation

jdx commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

gemini-code-assist bot commented Feb 18, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2026

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jdx commented Feb 18, 2026 •

edited

Loading

`mise x -- echo`

`mise env`

`mise hook-env`

`mise ls`

`xtasks/test/perf`