Skip to content

Conversation

@jdx
Copy link
Owner

@jdx jdx commented Jan 20, 2026

Summary

  • Adds the same skip pattern used by fish, bash, and zsh tests to the PowerShell test
  • Allows the test to gracefully skip when pwsh is not available instead of failing

The other shell tests all have this pattern:

if Command::new("fish").arg("--version").output().is_err() {
    eprintln!("Skipping fish test - fish shell not installed");
    return;
}

This PR adds the equivalent for PowerShell.

Test plan

  • Test skips gracefully when pwsh is not installed
  • Test runs normally when pwsh is available

🤖 Generated with Claude Code


Note

Test reliability

  • Adds a guard in test_powershell_completion_integration to detect missing pwsh and skip with a message
  • Aligns PowerShell test behavior with fish/bash/zsh completion tests; no other changes

Written by Cursor Bugbot for commit 7858c49. This will update automatically on new commits. Configure here.

Adds the same skip pattern used by fish, bash, and zsh tests to the
PowerShell test, allowing it to gracefully skip when pwsh is not
available instead of failing.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings January 20, 2026 23:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a graceful skip mechanism to the PowerShell completion integration test when PowerShell Core (pwsh) is not installed. This aligns the PowerShell test with the existing pattern used by fish, bash, and zsh tests, preventing test failures in environments without PowerShell.

Changes:

  • Added pwsh availability check at the beginning of test_powershell_completion_integration()
  • Updated comment from "NO skip - CI must have pwsh installed" to "Skip if pwsh is not installed"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.36%. Comparing base (33dda62) to head (7858c49).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files          47       47           
  Lines        7221     7221           
  Branches     7221     7221           
=======================================
  Hits         3276     3276           
  Misses       1987     1987           
  Partials     1958     1958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jdx jdx merged commit 7ff8eb6 into main Jan 21, 2026
11 checks passed
@jdx jdx deleted the fix/skip-pwsh-test branch January 21, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants