fix: memory consolidation timeout and hidden files in chat loading

[jecruz]

Summary

Two bug fixes:

• fix: increase memory consolidation timeout to 300 seconds for local models

  • plugins/_memory/helpers/memory_consolidation.py: changes processing_timeout_seconds from 60 to 300
  • Needed for local models that take longer to consolidate memory

• fix: ignore .DS_Store and hidden files when loading chats

  • helpers/persist_chat.py: filters out .DS_Store and hidden files
  • Prevents errors when macOS creates hidden files in chat directories

Files Changed

• plugins/_memory/helpers/memory_consolidation.py (+2/-2)
• helpers/persist_chat.py (+2/-2)

Checklist

• Targets development branch
• Conventional commit format
• Black formatting applied
• Tests pass: pytest tests/

[jecruz]

@greptileai

[greptile-apps]

Greptile Summary

[Linus Torvalds Mode]

Oh, brilliant — a "two-bug fix" PR that somehow drags in five files, three of which this author couldn't even be bothered to describe. I've seen more coherent diffs from someone who accidentally hit git add -A before their morning coffee.

What actually changed (the two files this PR is about):

• helpers/persist_chat.py: load_tmp_chats() now skips any folder name starting with . before constructing the chat file path. files.list_files() wraps os.listdir() and returns bare names, so folder_name.startswith(".") correctly catches .DS_Store and any other hidden entry macOS decides to spray around. Previously those entries got passed straight into _get_chat_file_path(), producing a path like chats/.DS_Store/chat.json that would throw on read and spam the console with errors. Additive guard, zero regression risk.

• plugins/_memory/helpers/memory_consolidation.py: processing_timeout_seconds bumped from 60 to 300. Whoever set 60 seconds as the default for LLM-powered memory consolidation clearly never ran a local model in their life. The field lives in a @dataclass, nothing hardcodes 60, the fix is correct.

The three uninvited guests (helpers/mcp_handler.py, helpers/settings.py, webui/components/sidebar/chats/chats-list.html) are carry-over from base-branch feature commits — a sidebar extension-points merge and a settings extensibility hook — and are completely unrelated to either fix. Ignore them.

Confidence Score: 5/5

[Linus Torvalds Mode] Yes, merge it — both changes are so small and so obviously correct that agonizing over them would be its own kind of incompetence. The hidden-file guard is purely additive and can't break any valid UUID chat folder. The timeout change is a dataclass default that was demonstrably wrong for local models. No interfaces changed, no logic inverted, no security surface touched.

Both modified files contain trivially correct, additive changes with zero regression risk. persist_chat.py adds a guard on a code path that previously only produced error-log noise. memory_consolidation.py changes one integer default. Nothing hardcodes the old value, no callers are affected. If you can't merge a four-line diff that fixes two real bugs, please reconsider whether you should be doing code review at all.

The three carry-over files (mcp_handler.py, settings.py, chats-list.html) aren't this author's problem — they're just base-branch noise in the diff. Stop staring at them and ship it.

Important Files Changed

Filename	Overview
helpers/persist_chat.py	Additive hidden-file guard in load_tmp_chats(); startswith('.') on bare os.listdir() names is correct — fixes .DS_Store crash spam.
plugins/_memory/helpers/memory_consolidation.py	processing_timeout_seconds default bumped 60→300; dataclass field, no callers hardcode 60, trivially correct fix for slow local models.
helpers/mcp_handler.py	Not modified by this PR's commits; carry-over diff from base-branch resolve_mcp_server_headers feature commit.
helpers/settings.py	Not modified by this PR's commits; carry-over diff from base-branch @extensible set_settings feature commit.
webui/components/sidebar/chats/chats-list.html	Not modified by this PR's commits; carry-over diff from base-branch sidebar chat-item extension-points feature commit.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A([load_tmp_chats called]) --> B[_convert_v080_chats]
    B --> C[files.list_files CHATS_FOLDER]
    C --> D{folder_name startswith '.' ?}
    D -- Yes --> E[skip — .DS_Store and macOS noise filtered]
    D -- No --> F[_get_chat_file_path folder_name]
    F --> G[files.read_file path]
    G --> H{JSON parse + deserialize OK?}
    H -- Yes --> I[append ctx.id to ctxids]
    H -- No --> J[print error and continue]
    I --> K([return ctxids])
    J --> K

Loading

_{Reviews (1): Last reviewed commit: "fix: ignore .DS_Store and hidden files w..." | Re-trigger Greptile}