Skip to content

Conversation

@jeertmans
Copy link
Owner

And renamed TriangleMesh.num_objects to TriangleMesh.num_primitives

@github-actions github-actions bot added documentation Improvements or additions to documentation ci Continuous integration (tests, lints, ...) python Changes Python code tests Changes tests dependencies Related to the project dependencies labels Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.37%. Comparing base (65b1d1a) to head (490b997).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   83.16%   83.37%   +0.20%     
==========================================
  Files          32       32              
  Lines        3018     3032      +14     
==========================================
+ Hits         2510     2528      +18     
+ Misses        508      504       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

And renamed `TriangleMesh.num_objects` to `TriangleMesh.num_primitives`
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 23, 2025

CodSpeed Performance Report

Merging #297 will degrade performances by 16.92%

Comparing sample-objects (490b997) with main (65b1d1a)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compute_paths_in_simple_street_canyon_scene[hybrid-False-20000-0] 6.7 s 8.1 s -16.92%
test_compute_paths_in_simple_street_canyon_scene[hybrid-False-20000-1] 9.9 s 6.2 s +58.87%

@jeertmans jeertmans merged commit 714a428 into main Jul 23, 2025
63 checks passed
@jeertmans jeertmans deleted the sample-objects branch July 23, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration (tests, lints, ...) dependencies Related to the project dependencies documentation Improvements or additions to documentation python Changes Python code tests Changes tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant