Skip to content

Conversation

@jeertmans
Copy link
Owner

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation visualization Related to visualization utilities python Changes Python code tests Changes tests labels Aug 7, 2025
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 90.62500% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.12%. Comparing base (ed863cf) to head (2d16a33).
⚠️ Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
differt/src/differt/rt/_utils.py 96.66% 2 Missing ⚠️
differt/src/differt/em/_material.py 0.00% 1 Missing ⚠️
differt/src/differt/geometry/_paths.py 0.00% 1 Missing ⚠️
differt/src/differt/geometry/_triangle_mesh.py 0.00% 1 Missing ⚠️
differt/src/differt/scene/_triangle_scene.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   83.49%   84.12%   +0.62%     
==========================================
  Files          32       32              
  Lines        3017     3023       +6     
==========================================
+ Hits         2519     2543      +24     
+ Misses        498      480      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 7, 2025

CodSpeed Performance Report

Merging #310 will degrade performances by 51.14%

Comparing batch_size (2d16a33) with main (ed863cf)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 4 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compute_paths[hybrid] 5.8 s 12 s -51.14%
test_first_triangles_hit_by_rays 5.9 s 4 s +46.56%
test_rays_intersect_any_triangle 4.3 s 3.2 s +33.08%
test_transmitter_visibility 965.6 ms 1,969 ms -50.96%

@jeertmans jeertmans changed the title feat(lib): better batch_size default, new arguments and fixes feat(lib): better batch_size default, new arguments Aug 19, 2025
@github-actions github-actions bot added ci Continuous integration (tests, lints, ...) dependencies Related to the project dependencies labels Sep 15, 2025
@jeertmans jeertmans merged commit 1e17b50 into main Sep 15, 2025
54 checks passed
@jeertmans jeertmans deleted the batch_size branch September 15, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration (tests, lints, ...) dependencies Related to the project dependencies documentation Improvements or additions to documentation python Changes Python code tests Changes tests visualization Related to visualization utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant