Update crypto library to prevent failing builds, make Build docs more verbose#4
Open
vile wants to merge 2 commits intojeffreyscholz:mainfrom
Open
Update crypto library to prevent failing builds, make Build docs more verbose#4vile wants to merge 2 commits intojeffreyscholz:mainfrom
Build docs more verbose#4vile wants to merge 2 commits intojeffreyscholz:mainfrom
Conversation
|
please merge this, helped me 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this repo through Rareskills, and wanted to test it out. Immediately ran into an issue where builds were failing (exact issue detailed in #3, and possibly fixes #2). Found this fix suggested in a completely unrelated repo issue thread (bytecodealliance/wasmtime#1758). Implementing this change did fix the issue, and builds are working (at least on an WSL env: 5.15.153.1-microsoft-standard-WSL2, Ubuntu 22.04.4 LTS)
Besides the above, the
Buildsection has been updated to be more verbose.