Add a article:modified_time property for articles#515
Open
CookiePLMonster wants to merge 2 commits intojekyll:masterfrom
Open
Add a article:modified_time property for articles#515CookiePLMonster wants to merge 2 commits intojekyll:masterfrom
CookiePLMonster wants to merge 2 commits intojekyll:masterfrom
Conversation
Contributor
Author
|
@ashmaroli I created this PR in response to our discussion in #505 - whichever PR ends up being merged, the other one (as well as #447) can be closed. |
615bd64 to
c1b77e3
Compare
Contributor
Author
|
Are there any blockers preventing this from moving forward? |
Member
|
Time, energy, and attention. Jekyll does not have any full time maintainers and we all have other demands on our time that are keeping most things from moving forward at the moment. Your patience is appreciated. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
article:modified_timemeta property, utilizing the sameseo_tagdrop values as JSON-LD does.Two other PRs adding this feature (#447 and #505) are also open, but my attempt has the following advantages:
seo_tagdrop values are used for complete consistency with the JSON-LD output. This ensures compatibility with bothpage.last_modified_atandseo.date_modifiedfront matter attributes. I also extended this to the published date instead of usingpage.datedirectly.seo.date_modifiedalso influences this new meta property.Verified working using my own website - on a test blog post, I can see a new meta property added:
The behaviour of adding the modification time even if it equals the publishing time matches jekyll-feed.