FIX JENKINS-54071#311
Conversation
FIX JENKINS-54071
| StreamTaskListener listener = new StreamTaskListener(sw); | ||
| EC2AbstractSlave node = t.attach(id, listener); | ||
| Jenkins.getActiveInstance().addNode(node); | ||
| Jenkins.getInstance().addNode(node); |
There was a problem hiding this comment.
Should use Jenkins.get() to avoid NPE, though I don't remember which version of Jenkins added that.
There was a problem hiding this comment.
At the moment the code is mainly using the getInstance(), and the getActiveInstance() is deprecated. If we want to move to jenkins.get() we should handle in a separate "global clean up"commit
There was a problem hiding this comment.
The issue is that the build does not pass right now. You need to fix those NPEs before we can merge this. Otherwise, this will break releases.
There was a problem hiding this comment.
yes, I am going to submit the patch for the problem reported by the findbugs
There was a problem hiding this comment.
It's amusing because Jenkins.getInstance() is a nullable method, but it wasn't an issue until they broke up the methods.
julienduchesne
left a comment
julienduchesne
left a comment
There was a problem hiding this comment.
Other than the possible NPEs found by findbugs, this LGTM
| StartInstancesRequest siRequest = new StartInstancesRequest(instances); | ||
| StartInstancesResult siResult = ec2.startInstances(siRequest); | ||
|
|
||
| StartInstancesResult siResult = ec2.startInstances(siRequest); |
3 participants
FIX JENKINS-54071