Add experimental agent page UI#26587
Conversation
move the controls to launch or mark offline to the main app-bar so it is available on each subpage
|
Thanks for this! Curious to explore if there's a way we can fit this in with the Manage Jenkins redesign/sidebar style. Would be nice to not have two clashing UIs. |
For users coming from the dashboard it would be consistent |
|
Maybe we can remove nodes from system configuration? That way they always come in through a consistent UI? |
| return MessageFormat.format(format, args); | ||
| } | ||
|
|
||
| @Restricted(NoExternalUse.class) |
There was a problem hiding this comment.
This in combination with the change in actions.jelly allows to not restrict the DeleteAgentAction to the new UI. It ensures that the delete is properly rendered in the sidepanel and works as expected
@janfaracik I think that can also be used for the job page
| </j:if> | ||
| <st:include page="sidepanel2.jelly" optional="true" /><!-- hook for derived class to add more items --> | ||
| <t:actions /> | ||
| <t:actions actions="${it.appBarActions}"/> |
There was a problem hiding this comment.
So the actions are not sorted by name but appear in the same order as they appear in the overflow menu
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
This PR adds an experimental agent page UI
What's new?
TODOs:
Testing done
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label rfe,web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.