Skip to content

JENKINS-73029 - Fix expanding special characters in results #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asimell merged 1 commit into from
May 17, 2024
Merged

JENKINS-73029 - Fix expanding special characters in results #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/main/resources/hudson/plugins/robot/util/failedCases.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<?xml version="1.0" encoding="UTF-8"?>
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:u="/util">
<j:if test="${!it.allFailedCases.isEmpty()}">
Expand All @@ -17,13 +17,15 @@
</tr>
<j:forEach var="case" items="${it.allFailedCases}">
<j:set var="fullName" value="${case.getRelativePackageName(it)}" />
<j:set var="relativeId" value="${case.getRelativeId(it)}" />
<j:set var="escapedName" value="${h.escape(fullName)}" />
<tr>
<td class="pane">
<a id="${h.escape(fullName)}-showlink" href="javascript:showStackTrace('${h.jsStringEscape(h.escape(fullName))}','${h.jsStringEscape(case.getRelativeId(it))}/summary')" class="expand"></a>
<a id="${h.escape(fullName)}-hidelink" style="display:none" href="javascript:hideStackTrace('${h.jsStringEscape(h.escape(fullName))}')" class="collapse"></a>
<a id="${escapedName}-showlink" href="#" onclick="javascript:showStackTrace('${h.jsStringEscape(escapedName)}','${h.jsStringEscape(relativeId)}/summary')" class="expand"></a>
Copy link
Copy Markdown

@Zoupers Zoupers Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the href="#" will cause the page relocate to the top when we expand the result.

<a id="${escapedName}-hidelink" href="#" onclick="javascript:hideStackTrace('${h.jsStringEscape(escapedName)}')" style="display:none" class="collapse"></a>
<st:nbsp/>
<a href="${case.getRelativeId(it)}"><small>${case.getRelativeParent(it)}</small>${case.name}</a>
<div id="${h.escape(fullName)}" class="hidden" style="display:none">
<a href="${relativeId}"><small>${case.getRelativeParent(it)}</small>${case.name}</a>
<div id="${escapedName}" class="hidden" style="display:none">
${%Loading...}
</div>
</td>
Expand Down