JENKINS-72538 - SKIP status configurable when calculating all tests#77
JENKINS-72538 - SKIP status configurable when calculating all tests#77
SKIP status configurable when calculating all tests#77Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @throws IOException thrown exception | ||
| * @throws ServletException thrown exception | ||
| */ | ||
| public FormValidation doCheckUnstableThreshold( |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation
| * @throws IOException thrown exception | ||
| * @throws ServletException thrown exception | ||
| */ | ||
| public FormValidation doCheckUnstableThreshold( |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
| * @throws IOException thrown exception | ||
| * @throws ServletException thrown exception | ||
| */ | ||
| public FormValidation doCheckPassThreshold(@QueryParameter String value) |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation
| * @throws IOException thrown exception | ||
| * @throws ServletException thrown exception | ||
| */ | ||
| public FormValidation doCheckPassThreshold(@QueryParameter String value) |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
src/test/java/hudson/plugins/robot/tokens/RobotPassRatioTokenMacroTest.java
Show resolved
Hide resolved
src/test/java/hudson/plugins/robot/tokens/RobotPassPercentageTokenMacroTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
add // TODO: remove test when criticality is removed to line 61
| #robot-summary-table .fail { | ||
| color: #f00; | ||
| } | ||
| #robot-summary-table .pass { |
There was a problem hiding this comment.
should we have yellow color here as well?
There was a problem hiding this comment.
This class is only used for the font colour in the summary table. Of course we could add a yellow colour in the skipped column if any tests were skipped, but then again we could also take colouring off the table altogether?
src/main/resources/hudson/plugins/robot/RobotStep/config.properties
Outdated
Show resolved
Hide resolved
src/main/resources/hudson/plugins/robot/RobotPublisher/config.properties
Outdated
Show resolved
Hide resolved
…properties Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
…est.java Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
…acroTest.java Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
…okenMacroTest.java Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
…rties Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
Tattoo
left a comment
Tattoo
left a comment
There was a problem hiding this comment.
one more addition to documentation
Co-authored-by: Tatu Kairi <280218+Tattoo@users.noreply.github.com>
3 participants
onlyCriticalflag. It no longer does anything, but is still kept to keep existing pipelines alive.getCriticalPassedandgetCriticalFailedfunctions. They will now just return overall passed/failed test cases.countSkippedTeststhat either ignores skipped tests when calculating pass percentage (current behaviour) or takes them into account (new behaviour)