Skip to content

improve link target on dashboard to a better results overview#82

Merged
Tattoo merged 1 commit intojenkinsci:masterfrom
DirkRichter:improve-log-link
Apr 17, 2025
Merged

improve link target on dashboard to a better results overview#82
Tattoo merged 1 commit intojenkinsci:masterfrom
DirkRichter:improve-log-link

Conversation

@DirkRichter
Copy link
Copy Markdown
Contributor

This pull request improves the link target on the Jenkins Robot Plugin dashboard to provide a better overview of the results. The link has been updated from report/log.html to report/report.html#totals, which directs users to a more relevant section of the report.

Testing done

I manually tested the change by navigating to the dashboard and clicking the updated link. The link now correctly redirects to the totals section of the report, providing a clearer overview of the results. I verified that the previous link (report/log.html) was replaced and that the new link functions as intended.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

@asimell
Copy link
Copy Markdown
Contributor

asimell commented Apr 17, 2025

log.html is not the same thing as report.html. Yes, it might give a better overview of all results, but often times people want to drill down to the errors immediately. There's a separate link to open report.html already. I don't believe replacing log.html to report.html is a good idea.

image

@Tattoo
Copy link
Copy Markdown
Member

Tattoo commented Apr 17, 2025

In addition, the link has worked this way for a more than a decade. Making backwards-incompatible change would annoy quite many users.

@DirkRichter
Copy link
Copy Markdown
Contributor Author

I think you misunderstood the change. It's not about changing the link in the Results View you provided (this is unchanged). It's about the column on Dashboard:
image
And as you agreed: "people want to drill down to the errors immediately", which is now possible with this change.
Now you do not need to scroll down on large log.html files to the errors. You will get an overview directly.

@asimell
Copy link
Copy Markdown
Contributor

asimell commented Apr 17, 2025

Oh that link. I had completely forgot that you could access the log file from there. Changing that could indeed make sense.

@Tattoo
Copy link
Copy Markdown
Member

Tattoo commented Apr 17, 2025

After discussion, we decided that this change indeed makes sense. Thanks for your patience @DirkRichter and righting our misunderstanding about the feature.

@Tattoo Tattoo merged commit db39ba1 into jenkinsci:master Apr 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants