Skip to content

Migrate tests to JUnit5#84

Merged
asimell merged 1 commit intojenkinsci:masterfrom
strangelookingnerd:migrate_to_junit5
Apr 24, 2025
Merged

Migrate tests to JUnit5#84
asimell merged 1 commit intojenkinsci:masterfrom
strangelookingnerd:migrate_to_junit5

Conversation

@strangelookingnerd
Copy link
Copy Markdown
Contributor

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations and imports
  • Migrate assertions
  • Remove public visibility for test classes and methods
  • Minor clean up

I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@asimell
Copy link
Copy Markdown
Contributor

asimell commented Apr 24, 2025

@strangelookingnerd Could you rebase this and resolve merge conflicts, please? I merged #83 this morning, which removed and refactored some tests.

* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor code cleanup
@strangelookingnerd
Copy link
Copy Markdown
Contributor Author

Rebased the PR. Bad timing on my end there 😄

@asimell
Copy link
Copy Markdown
Contributor

asimell commented Apr 24, 2025

No worries, thanks for quick reaction!

@asimell asimell merged commit adb6df5 into jenkinsci:master Apr 24, 2025
17 checks passed
@strangelookingnerd strangelookingnerd deleted the migrate_to_junit5 branch April 24, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants