JENKINS-76150 - Check for empty string before parsing endtime#90
Merged
asimell merged 1 commit intojenkinsci:masterfrom Oct 9, 2025
Merged
JENKINS-76150 - Check for empty string before parsing endtime#90asimell merged 1 commit intojenkinsci:masterfrom
asimell merged 1 commit intojenkinsci:masterfrom
Conversation
asimell
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elapsedtime != 0is not a conclusive test to determine whether we are converting the older version of the data file (withoutelapsedtime, which defaults to0when the@CheckForNullannotation is absent) or the newer version whereelapsedtimejust happens to be0. In the latter case, we should not attempt to parseendtime, since it will be empty and will cause an error to be logged. This commit adds this check.