Add waitNextEventLoopTurnForUnhandledRejectionEvents flag#14681
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Sweet, thanks! Could you fix the ESLint and snapshot errors? |
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
barring CI and some tiny docs tweaks, this LGTM! 😀
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
instead of deleting/changing back the tests this feature caused in the first place, could we run Jets twice, with and without the config active?
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Wonderful stuff, thank you!
Sorry for all the back and forth, I appreciate you sticking with me on this! 👍
|
No problem! I am happy to make it land eventually |
stekycz
deleted the
stekycz-flag-waitNextEventLoopTurnForUnhandledRejectionEvents
branch
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
Followup on #14315
Summary
Adds
waitNextEventLoopTurnForUnhandledRejectionEventsflag to await for the next even loop turn to correctly detect unhandled promise rejections in tests. See #14315 (comment) for more detailsThe feature of correct detection of unhandled promise rejections adds one event loop turn to every hook and test. It may have negative performance impact on test suites with many tests and hooks.