Skip to content

feat: add a waitBeforeRetry option to jest.retryTimes (#14737)#14738

Merged
SimenB merged 9 commits intojestjs:mainfrom
WillianAgostini:feat/14737
Dec 25, 2023
Merged

feat: add a waitBeforeRetry option to jest.retryTimes (#14737)#14738
SimenB merged 9 commits intojestjs:mainfrom
WillianAgostini:feat/14737

Conversation

@WillianAgostini
Copy link
Contributor

@WillianAgostini WillianAgostini commented Dec 4, 2023

Summary

Fixes #14737 adding a new option waitBeforeRetry to jest.retryTimes

Test plan

The tests have been updated.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 4, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 89ed2d1
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/65895ed3f9d16300085855fb
😎 Deploy Preview https://deploy-preview-14738--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WillianAgostini WillianAgostini mentioned this pull request Dec 5, 2023
Open
@WillianAgostini WillianAgostini force-pushed the feat/14737 branch 2 times, most recently from 3792d3d to 0f0f7e1 Compare December 23, 2023 17:40
SimenB
SimenB requested changes Dec 24, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! in addition to my inline question, could you update the changelog?

packages/jest-circus/src/run.ts
await dispatch({name: 'test_retry', test});

if (waitBeforeRetry > 0) {
await new Promise(resolve => setTimeout(resolve, waitBeforeRetry));
Copy link
Member

@SimenB SimenB Dec 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this setTimeout work if fake timers are active? This code runs within the sandbox of user code, so we have to for instance make sure Date.now is the real one:

jest/scripts/babel-plugin-jest-native-globals.js

Lines 20 to 22 in 6ead171

const nowDeclaration = template(`
var jestNow = globalThis[Symbol.for('jest-native-now')] || globalThis.Date.now;
`);

Copy link
Contributor Author

@WillianAgostini WillianAgostini Dec 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does using const {setTimeout} = globalThis; solve this?

3707c1a

Copy link
Member

@SimenB SimenB Dec 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that should work

@SimenB
Copy link
Member

SimenB commented Dec 24, 2023

Wait, CI seems unhappy

@WillianAgostini
Copy link
Contributor Author

WillianAgostini commented Dec 25, 2023

hi @SimenB
This bug step:7:61 is related to what?

@SimenB
Copy link
Member

SimenB commented Dec 25, 2023

hi @SimenB This bug step:7:61 is related to what?

That's just some CI flake. Which is very annoying, but fine to ignore 🙂

SimenB
SimenB approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit e20a4be into jestjs:main Dec 25, 2023
@WillianAgostini WillianAgostini deleted the feat/14737 branch December 25, 2023 11:48
@github-actions
Copy link

github-actions bot commented Jan 25, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: add a waitBeforeRetry option to jest.retryTimes

2 participants

@WillianAgostini @SimenB