Merged
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
requested changes
Feb 29, 2024
SimenB
requested changes
Feb 29, 2024
Member
SimenB
left a comment
There was a problem hiding this comment.
Thanks! could you also add a changelog entry?
SimenB
reviewed
Mar 2, 2024
CheadleCheadle
commented
Mar 2, 2024
Contributor
Author
CheadleCheadle
left a comment
There was a problem hiding this comment.
looks good to me!
Member
|
From reading the docs, it seems
I'll fix both 🙂 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14923
Jest and libraries support using
import { createRequire } from 'node:module';const require = createRequire(import.meta.url);to resolve relative paths.This was a useful convention for a while, but now we have import.meta.resolve(…) to express a relative path resolution.
It is supported by all major browsers and all major runtimes.
import.meta.resolveSupport: Jest now supports the import.meta.resolve function, allowing users to resolve module specifiers in a manner consistent with the standard JavaScript module system.Test plan
Successfully resolves paths
Note: This is an initial, primitive implementation and currently supports basic resolution functionality. I am interested in what features such as support for dynamic string values should be incorporated.