refactor(jest-environment)!: remove unnecessary defensive code#15045
Merged
SimenB merged 2 commits intojestjs:mainfrom May 12, 2024
mrazauskas:remove-defensive-code
Merged
refactor(jest-environment)!: remove unnecessary defensive code#15045SimenB merged 2 commits intojestjs:mainfrom mrazauskas:remove-defensive-code
SimenB merged 2 commits intojestjs:mainfrom
mrazauskas:remove-defensive-code
Conversation
mrazauskas
changed the title
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mrazauskas
commented
Apr 30, 2024
Comment on lines
-2270
to
-2272
| (() => { | ||
| throw new Error( | ||
| 'Your test environment does not support `mocked`, please update it.', |
Contributor
Author
There was a problem hiding this comment.
This and following cases are not marked as to be removed in Jest 30, but seem to be unnecessary as well.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes unnecessary defensive code which was planned (mostly) to be removed in Jest 30.
Test plan
Green CI.