fix: refactor _importCoreModule so required core module is consistent#15517
fix: refactor _importCoreModule so required core module is consistent#15517SimenB merged 4 commits intojestjs:mainfrom
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for the PR! Mind adding a test that covers the bug as well? |
|
@SimenB Given the original bug's flakiness, is it a good idea to test the private method |
SimenB
left a comment
There was a problem hiding this comment.
I was thinking we could do an integration test where we add a property to a node core module while it's loading, but I think it'd be fiddly as we cache the module, so we'd have to do something in parallel and somehow time it right. Doesn't sound like a stable test at all, so let's ship this as-is 👍
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #15077