-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix: refactor _importCoreModule so required core module is consistent #15517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for the PR! Mind adding a test that covers the bug as well? |
|
@SimenB Given the original bug's flakiness, is it a good idea to test the private method |
SimenB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we could do an integration test where we add a property to a node core module while it's loading, but I think it'd be fiddly as we cache the module, so we'd have to do something in parallel and somehow time it right. Doesn't sound like a stable test at all, so let's ship this as-is 👍
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #15077