Skip to content

Conversation

@eyalroth
Copy link
Contributor

@eyalroth eyalroth commented Jun 18, 2025

Summary

Fixes #15678.

First commit also makes sure to run jest-environment-node tests will every combination of the globalsCleanup configuration.

@netlify
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 429cf37
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/6852bd22a8ad4100081b1d24
😎 Deploy Preview https://deploy-preview-15684--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 18, 2025

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15684

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15684

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15684

create-jest

npm i https://pkg.pr.new/create-jest@15684

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15684

expect

npm i https://pkg.pr.new/expect@15684

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15684

jest

npm i https://pkg.pr.new/jest@15684

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15684

jest-circus

npm i https://pkg.pr.new/jest-circus@15684

jest-cli

npm i https://pkg.pr.new/jest-cli@15684

jest-config

npm i https://pkg.pr.new/jest-config@15684

@jest/console

npm i https://pkg.pr.new/@jest/console@15684

@jest/core

npm i https://pkg.pr.new/@jest/core@15684

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15684

jest-diff

npm i https://pkg.pr.new/jest-diff@15684

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15684

jest-each

npm i https://pkg.pr.new/jest-each@15684

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15684

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15684

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15684

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15684

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15684

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15684

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15684

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15684

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15684

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15684

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15684

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15684

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15684

jest-mock

npm i https://pkg.pr.new/jest-mock@15684

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15684

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15684

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15684

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15684

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15684

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15684

jest-runner

npm i https://pkg.pr.new/jest-runner@15684

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15684

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15684

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15684

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15684

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15684

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15684

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15684

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15684

@jest/types

npm i https://pkg.pr.new/@jest/types@15684

jest-util

npm i https://pkg.pr.new/jest-util@15684

jest-validate

npm i https://pkg.pr.new/jest-validate@15684

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15684

jest-worker

npm i https://pkg.pr.new/jest-worker@15684

pretty-format

npm i https://pkg.pr.new/pretty-format@15684

commit: 429cf37

@eyalroth eyalroth force-pushed the 15678-globalscleanup-off-no-protection branch from 40a9867 to 760523a Compare June 18, 2025 12:46
@eyalroth eyalroth force-pushed the 15678-globalscleanup-off-no-protection branch from 760523a to 429cf37 Compare June 18, 2025 13:20
@eyalroth eyalroth marked this pull request as ready for review June 18, 2025 13:36
@eyalroth
Copy link
Contributor Author

@cpojer not sure if you saw but this PR is ready for review :)

(I can't seem to be able to use the "request review" feature)

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll publish a new release.

@cpojer cpojer merged commit 33820ad into jestjs:main Jun 18, 2025
74 of 76 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: globalsCleanup causes issues with some deps, can't be properly turned off

2 participants