Add missing languages and correct translations of languages.#1161
Merged
Conversation
Japanese and Portuguese were not added to the translations. Japanese locale strings need to be in Japanese. Portuguese locale strings need to be in Portuguese. Chinese (Traditional) locale strings need to be in Chinese (Traditional). Always use (bokmål) for "book language" Norwegian. Resorted using `npm run i18n:resort`
IDisposable
commented
Jan 27, 2026
Needed to document the steps for adding the other languages.
Contributor
Author
They should be in the native language of the containing file.
adamshiervani
approved these changes
Jan 27, 2026
Contributor
adamshiervani
left a comment
There was a problem hiding this comment.
Looks good to me. Just one small docs change.
Sorted language codes (leaving English at top as default) Address review comments.
Japanese was never added.
Contributor
Author
Added a generic helper function that maps localized messages to their inlang/paraglide formatting function.
adamshiervani
approved these changes
Jan 28, 2026
Contributor
adamshiervani
left a comment
There was a problem hiding this comment.
Just need that Japanese bokmål fix and then we'r good to go! Great catch
Contributor
Author
Updated and pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
"locale_*":should be in the language OF the containing locale file. For example, in the locale_pt.json, we should have"locale_en": "Inglês". This is different from the locale_en.json which always shows the name in the native language of the locale being represented, e.g."locale_es": "Español",is the Spanish way of saying spanish.Changes
"locale_en": "英語",for English)"locale_es": "西班牙語",for Spanish)"locale_zh": "Kinesisk (forenklet)",for the Danish translation of Chinese)npm run i18n:resortfor diff-stability latergetLocalizedMessagethat allows dynamic access to the localized strings and updated themap_locale_code_to_nameto use it so we don't need to also update the previousswitchstatement.Checklist
make test_e2elocally and passedCloses #<issue-number>)