Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
Liquid2::Scannerand changesLiquid2::Environmentto allow for custom markup delimiters, which default to{{and}}for output statements,{%and%}for tags and{#and#}for comments.For example, we can change all those curly brackets to be square brackets.
And configure multiple environments with different delimiters.
This feature does mean the tokenizer is slightly slower now then when we had hard coded delimiters, but I'm inclined to go with it.
A word of warning though, both
]]and))from the examples above can appear in standard Liquid expressions. So one would need to pick more elaborate delimiters that don't include existing punctuation, or accept that some syntax will not be available.