Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for arithmetic operators
+,-,*,/,%and**.These operators are disabled by default. Enable them by passing
arithmetic_operators: truewhen constructing a newLiquid2::Environment.By default, arithmetic operators follow the same semantics as their filter equivalents and follow the usual operator precedence rules. I intend to add an option to change
/anddivide_byto not do integer division, and enable//andfloor_divide_by. This will probably be done in a different pull request.Yet another option to return
undefinedor infinity instead of raising aZeroDivisionErrororLiquidTypeErrorwhen dividing by zero might be good too.