Open
Conversation
Previously we had `foldr applyPipe (reverse pipes)`, with monadic
pipes we had to change the `foldr` to `foldM` and so we should no
longer reverse the list as witnessed by the following repl session:
> foldr (\x ih -> traceShow x x + ih) 0 (reverse [1,2,3])
1
2
3
6
> foldM (\ih x -> print x >> return (x + ih)) 0 [1,2,3]
1
2
3
6
This makes all tests pass again.
Owner
|
Why monadic and not just a pure function? A pure function would handle the cases mentioned in #11. Also, what's the intended use of the text arguments? Example? |
Author
I found myself wanting to do
There's an example in the tests, (I realised after I made this PR that I actually needed input data dependent arguments, i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also needed custom pipes and saw #11 with the comment:
So I thought I'd give it a try.