Merged
Conversation
Previously the template turned any `keywords` defined in Pandoc metadata into empty objects due to a misnomer in a loop variable. This in turn was rejected by the Typst compiler as invalid syntax, making document generation with keywords impossible.
Contributor
Author
|
I know the contributing guide asks to write tests, but I'm not familiar with this repository and I don't see any tests for other language templates. Do you think this change requires a test and if so, where should I add it? |
Owner
|
Thanks! I don't think we need a test for this, which is clearly correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the template turned any
keywordsdefined in Pandoc metadata into empty objects due to a misnomer in a loop variable. This in turn was rejected by the Typst compiler as invalid syntax, making document generation with keywords impossible.