Do not override is-rounded with button-small. Fixes #3163.#3208
Merged
jgthms merged 1 commit intojgthms:masterfrom Dec 20, 2020
Merged
Do not override is-rounded with button-small. Fixes #3163.#3208jgthms merged 1 commit intojgthms:masterfrom
jgthms merged 1 commit intojgthms:masterfrom
Conversation
Owner
|
Thanks, I like this solution. |
This was referenced May 24, 2024
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix for #3163.
Proposed solution
button-smallcurrently assumes the button is not rounded and overrides its border-radius from$radiusto$radius-small. This is not valid however ifis-roundedis applied to the button.This PR adds
&:not(.is-rounded)to avoid this. This solution is preferable to #3164 which uses!important.Tradeoffs
None
Testing Done
Tested with the following code:
Bulma
v0.9.1incorrectly renders the button not rounded. Test and confirmed that this PR causes the button to be correctly rendered small and rounded.Changelog updated?
No.