This repository was archived by the owner on Apr 18, 2025. It is now read-only.
First stab at refactoring to use the new built in artifact-url output#46
Open
acoffman wants to merge 15 commits intocansavvy/updatefrom
Open
First stab at refactoring to use the new built in artifact-url output#46acoffman wants to merge 15 commits intocansavvy/updatefrom
acoffman wants to merge 15 commits intocansavvy/updatefrom
Conversation
Contributor
|
This looks great! Thanks for getting this going. So glad to hear they've added this functionality! Let's make this something we can test! |
Contributor
|
Hi @acoffman just wanted to check in on this. I have some other work I want to do for this repository but wanted to see how what you are working on looks so I can make sure everything gets incorporated smoothly. Let me know! |
Closed
Contributor
|
It's working! https://github.com/cansavvy/test-course/pull/2 |
Contributor
|
I also copied over your work here to the new org over here https://github.com/ottrproject/ottr-reports/pull/3/files |
cansavvy
added a commit
to ottrproject/ottr-reports
that referenced
this pull request
Apr 3, 2025
Bringing over Adam's work from jhudsl/ottr-reports#46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @cansavvy,
I was working on porting the code here: https://github.com/orgs/community/discussions/51403#discussioncomment-5515349 to a generic, reusable action which led me to reading the docs for actions/upload-artifact as the version listed in the discussion answer is deprecated.
It turns out that, based on the release notes and the documented outputs, the artifact URL is now available directly as an output of the upload-artifact action.
This PR is a first stab at refactoring your refactor (in #44) to utilize this fact.
Now the primary action handles generating the reports, uploading them as artifacts, and managing the comments all in one workflow. There shouldn't be a need for the secondary commenter workflow or the API manipulation any longer.
Let me know if you think this makes sense and is the proper direction to take this workflow. If so, I need to do some more cleanup and testing and can go ahead and update the docs as part of this PR as well. (I just didn't want to go too far down this road if you think its the wrong way).