Skip to content

feat (read packet): better error for TLS attempt on non-TLS conn #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimlambrt merged 1 commit into from
May 1, 2023
Merged

feat (read packet): better error for TLS attempt on non-TLS conn #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,11 @@ func (c *conn) readPacket(requestID int) (*packet, error) {
c.mu.Lock()
defer c.mu.Unlock()
berPacket, err := ber.ReadPacket(c.reader)
if err != nil {
return nil, fmt.Errorf("%s: error reading ber packet for %d/%d: %w", op, c.connID, requestID, err)
switch {
case err != nil && strings.Contains(err.Error(), "invalid character for IA5String at pos 2"):
return nil, fmt.Errorf("%s: error reading ber packet for %d/%d (possible attempt to use TLS with a non-TLS server): %w", op, c.connID, requestID, err)
case err != nil:
return nil, fmt.Errorf("%s: error reading ber packet for %d/%d: %w", op, c.connID, requestID, err)
}
return berPacket, nil
}()
Expand Down