fix: remove matchedDN and diagnosticMessage from SearchResponseEntry#58
Merged
jimlambrt merged 1 commit intojimlambrt:mainfrom Jan 15, 2024
Merged
fix: remove matchedDN and diagnosticMessage from SearchResponseEntry#58jimlambrt merged 1 commit intojimlambrt:mainfrom
matchedDN and diagnosticMessage from SearchResponseEntry#58jimlambrt merged 1 commit intojimlambrt:mainfrom
Conversation
Owner
|
If there's no rush and you don't mind: I'll take a look after the holiday. |
Contributor
Author
|
Yes, of course! 😄 Happy holidays and Merry Christmas! |
jimlambrt
requested changes
Jan 3, 2024
Owner
jimlambrt
left a comment
jimlambrt
left a comment
There was a problem hiding this comment.
This looks great. Would you mind rebase on main so CI will be happy before we approve and merge?
Owner
|
@xunleii I know things are always busy after the holidays, but I'm just following up about rebasing this so we can merge it. |
Contributor
Author
Hi, sorry, I've seen your message but totally forgot just after. Thanks for the reminder 😄 |
Following some LDAP UI and Wireshark, these two elements should not be found inside a SearchResponseEntry (matchedDN doesn't make sense on this kind of message). Also, following https://ldap.com/ldapv3-wire-protocol-reference-search/, I didn't found anything about them: ``` SearchResultEntry ::= [APPLICATION 4] SEQUENCE { objectName LDAPDN, attributes PartialAttributeList } PartialAttributeList ::= SEQUENCE OF partialAttribute PartialAttribute LDAPDN ::= LDAPString -- Constrained to [RFC4514] LDAPString ::= OCTET STRING -- UTF-8 encoded, -- [ISO10646] characters PartialAttribute ::= SEQUENCE { type AttributeDescription, vals SET OF value AttributeValue } AttributeDescription ::= LDAPString -- Constrained to -- [RFC4512] AttributeValue ::= OCTET STRING ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Firstly, thanks for this library !!
This PR removes
matchedDNanddiagnosticMessagefromSearchEntryResponsebecause they should not be found here.