Skip to content

ProductSplit uses ProductSection#6

Merged
jishnub merged 2 commits intomasterfrom
ProductSection
Dec 22, 2020
Merged

ProductSplit uses ProductSection#6
jishnub merged 2 commits intomasterfrom
ProductSection

Conversation

@jishnub
Copy link
Copy Markdown
Owner

@jishnub jishnub commented Dec 21, 2020

Also Improvement in whichproc

on master:

julia> xrange_long, yrange_long, zrange_long = 1:3000, 1:3000, 1:3000;

julia> params_long = (xrange_long, yrange_long, zrange_long);

julia> ps = ProductSplit(params_long, 10, 3);

julia> val = (10,2,901);

julia> @btime whichproc($params_long, $val, 10)
  1.224 μs (14 allocations: 448 bytes)
4

after this PR:

julia> @btime whichproc($params_long, $val, 10)
  357.481 ns (0 allocations: 0 bytes)
4

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 21, 2020

Codecov Report

Merging #6 (523a0ca) into master (37af17d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   99.71%   99.71%   -0.01%     
==========================================
  Files           8        8              
  Lines        1061     1060       -1     
==========================================
- Hits         1058     1057       -1     
  Misses          3        3              
Impacted Files Coverage Δ
src/errors.jl 100.00% <ø> (ø)
src/productsplit.jl 100.00% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37af17d...523a0ca. Read the comment docs.

@jishnub jishnub merged commit 9385b59 into master Dec 22, 2020
@jishnub jishnub deleted the ProductSection branch December 22, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant