Define pmapreduce as a parallel to mapreduce, and pmapbatch as a parallel to pmap#9
Merged
Define pmapreduce as a parallel to mapreduce, and pmapbatch as a parallel to pmap#9
pmapreduce as a parallel to mapreduce, and pmapbatch as a parallel to pmap#9Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 99.71% 99.88% +0.16%
==========================================
Files 8 6 -2
Lines 1060 846 -214
==========================================
- Hits 1057 845 -212
+ Misses 3 1 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes several breaking changes, but the result is perhaps more consistent now with
BaseandDistributed.Now
pmapreduceparallelsmapreduce, so moving from a serial implementation to a parallel one can be achieved simply through a change in the name of the function.The function
pmapbatchnow parallelspmap, except the values are necessarily passed in contiguous batches to the mapped function.Also the commutative functions are removed. An operator may be declared to be commutative through the
Commutativetag.The reduction functions are cleaned up. Several in-place reduction operators are introduced for convenience.