Remove closure allocations in two methods #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was benchmarking a few caching libraries and noticed two closure allocations which can be avoided.
FastCache.GetOrAddwas using theTArgoverload ofConcurrentDictionary(as pointed out by A few small issues #1 and fixed by ebef51e), but it was still capturingvalueFactoryvariable. I changedTArgto a tuple of the two variables needed.FastCache.AddOrUpdatecould be similarly changed to use another overload and prevent capturingttlValuevariable.I ran the project benchmark on my machine with the following results:
Main branch (3e9a35a)
This PR (686fd04)