fix: whiteboard reopening when toggling lobby after hiding whiteboard#17105
fix: whiteboard reopening when toggling lobby after hiding whiteboard#17105vishal2005025 wants to merge 1 commit intojitsi:masterfrom
Conversation
|
@saghul @damencho @jallamsetty1 Please take a look and let me know if any changes are required. |
|
Hi, thanks for your contribution! |
| if (metadata?.[WHITEBOARD_ID]) { | ||
| const existingCollabDetails = getCollabDetails(state); | ||
| const { collabDetails } = metadata[WHITEBOARD_ID]; | ||
| const hasNewCollabDetails = existingCollabDetails?.roomId !== collabDetails?.roomId |
There was a problem hiding this comment.
Just in case we ever introduce new stuff, use lodash's "equal" helper.
7d99e56 to
ececd44
Compare
|
@saghul Thanks for the review - I’ve updated the comparison to use |
|
@saghul The same issue also exists on Android, so this fix should cover Android as well. Ci jobs: https://github.com/vishal2005025/jitsi-meet/actions/runs/22794105721 |
ececd44 to
067250c
Compare
|
@saghul @damencho @jallamsetty1 I noticed the same issue where after opening and hiding the whiteboard in a breakout room, leaving the breakout room could reopen it in the background. This happens because the room transition triggers a metadata refresh that is interpreted as a new whiteboard session. I fixed this by adding a small room-switch guard in the shared whiteboard middleware so the first metadata-driven auto-open is skipped during breakout room transitions. The previous behavior remains unchanged, and both issues are now resolved and working as expected. Please take a look. |
Summary
This PR fixes an issue where the whiteboard could reopen in the background after being hidden, when the moderator later toggled Lobby from Security options.
Problem
After the sequence:
the whiteboard reopened unexpectedly, even though the lobby action is unrelated.
Root Cause
Whiteboard middleware was reopening whiteboard on conference metadata updates whenever whiteboard metadata existed, even when that metadata was not new.
Lobby toggling can trigger metadata updates, which unintentionally retriggered whiteboard open.
Changed
Updated
react/features/whiteboard/middleware.any.tsso whiteboard auto-open runs only when whiteboard collaboration details are new/changed (roomId/roomKey changed), instead of on every metadata refresh.Before fix
before-lobby.mp4
After fix
after-lobby.mp4
Note:
This issue is reproducible on meet.jit.si