fix : prevent memory leak in MessageMenu setTimeout cleanup#17120
Open
Amanyadav0315 wants to merge 1 commit intojitsi:masterfrom
Open
fix : prevent memory leak in MessageMenu setTimeout cleanup#17120Amanyadav0315 wants to merge 1 commit intojitsi:masterfrom
Amanyadav0315 wants to merge 1 commit intojitsi:masterfrom
Conversation
- Add timeoutRef to store setTimeout reference - Clear existing timeout before setting new one - Add useEffect cleanup to clear timeout on unmount - Fix missing handleClose dependency in useCallback - Prevents memory leaks when component unmounts during 2s notification
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
MessageMenucomponent currently has a memory leak. When a user clicks "Copy" and the 2-second "Message Copied" notification is active, if the component unmounts before the timeout completes, the state update tries to run on an unmounted component. This can lead to memory leaks and runtime errors.Solution
To fix this, we made a few improvements:
useRefto keep track of thesetTimeout.useEffectclears the timeout when the component unmounts.handleCloseto theuseCallbackdependency array.Benefits
Testing
Learnings
This update highlights proper React patterns for managing side effects:
useRefto store mutable values like timeout IDs.useEffect.useCallbackto avoid stale closures.