Skip to content

TerminalGraphicsTest tests don't validate actual terminal graphics behavior #1809

@gnodet

Description

@gnodet

Two tests in terminal/src/test/java/org/jline/terminal/impl/TerminalGraphicsTest.java don't actually test what their names and docs imply:

  • testGhosttyKittyGraphicsSupport (line ~160): Should verify kitty graphics support for Ghostty terminal but doesn't validate actual behavior
  • testNoKittyGraphicsSupportForListedTerminals (line ~180): Should verify that listed terminals lack kitty support but doesn't validate actual behavior

These tests should be updated to actually assert the expected terminal graphics capabilities.

Found during review of #1794.

Claude Code on behalf of Guillaume Nodet

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions