Skip to content

chore: suppress deprecation warnings in tests for deprecated console API#1764

Merged
gnodet merged 1 commit into
masterfrom
fix/suppress-deprecation-warnings
Apr 7, 2026
Merged

chore: suppress deprecation warnings in tests for deprecated console API#1764
gnodet merged 1 commit into
masterfrom
fix/suppress-deprecation-warnings

Conversation

@gnodet
Copy link
Copy Markdown
Member

@gnodet gnodet commented Apr 7, 2026

Summary

  • Add @SuppressWarnings("deprecation") to 3 test classes that intentionally use the deprecated org.jline.console API (replaced by org.jline.shell in 4.0)
  • Affected files: SystemRegistryImplTest, Console example, PicocliCommandRegistryTest
  • The new org.jline.shell API already has its own test coverage (ArgumentDescriptionTest, CommandDescriptionTest, CommandLineTest, ShellBuilderTest)

Test plan

  • CI build should show no deprecation warnings from these files
  • Existing tests pass unchanged

Test classes that intentionally exercise the deprecated org.jline.console
API (replaced by org.jline.shell in 4.0) now have @SuppressWarnings("deprecation")
to keep the build warning-free. The new API has its own test coverage in the
shell module.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 7, 2026

Warning

Rate limit exceeded

@gnodet has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 7 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 7 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2e9740f2-2e69-4533-bf3b-bf2be15c3aa9

📥 Commits

Reviewing files that changed from the base of the PR and between 97baf7b and fb8f0e2.

📒 Files selected for processing (3)
  • console/src/test/java/org/jline/console/impl/SystemRegistryImplTest.java
  • console/src/test/java/org/jline/example/Console.java
  • picocli/src/test/java/org/jline/picocli/PicocliCommandRegistryTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/suppress-deprecation-warnings

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

@gnodet gnodet added the chore label Apr 7, 2026
@gnodet gnodet added this to the 4.0.11 milestone Apr 7, 2026
@gnodet gnodet merged commit bbe5f1b into master Apr 7, 2026
11 checks passed
@gnodet gnodet deleted the fix/suppress-deprecation-warnings branch April 7, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant