fix: guard waitDirty against spurious wakeups

[gnodet]

Summary

• Fix SonarCloud java:S2274: Object.wait(timeout) in ScreenTerminal.waitDirty(long) was not in a while loop, making it vulnerable to spurious wakeups.
• Uses a deadline-based while loop to correctly re-check the dirty flag and compute remaining timeout after each wakeup.

This was flagged as a new issue on PR #1758.

Summary by CodeRabbit

Bug Fixes

• Improved timeout handling for screen terminal operations with refined deadline-based calculation, ensuring more reliable and precise timing behavior during screen updates and reducing potential timing-related issues.

[coderabbitai]

Warning

Rate limit exceeded

@gnodet has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 21 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 7 minutes and 21 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce3ba3d0-bdec-412d-b744-b1504ca89f55

📥 Commits

Reviewing files that changed from the base of the PR and between fdb4adf and aa29592.

📒 Files selected for processing (1)

• builtins/src/main/java/org/jline/builtins/ScreenTerminal.java

📝 Walkthrough

Walkthrough

The waitDirty(long timeout) method in ScreenTerminal.java was refactored from a single wait(timeout) call to a loop-based implementation using System.nanoTime() to compute an absolute deadline, ensuring the wait condition is rechecked after each wakeup.

Changes

Cohort / File(s)	Summary
Timeout Polling Loop builtins/src/main/java/org/jline/builtins/ScreenTerminal.java	Refactored waitDirty(long timeout) to use loop-based polling with absolute deadline calculation via System.nanoTime(), replacing single wait(timeout) call with repeated wait(millis, nanos) invocations that recalculate remaining time until deadline or dirty flag is set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A timeout loop hops 'round and 'round,
With nanoTime precision, so profound,
Each wakeup checks the dirty flag anew,
Deadline-aware, through and through! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: protecting the waitDirty method against spurious wakeups through proper loop-based waiting.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/screen-terminal-sonarcloud

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud