fix: use terminal encoding instead of default charset in VirtualTerminal (fixes #1821)

[gnodet]

The MasterOutputStream in VirtualTerminal used Charset.defaultCharset() to decode terminal output bytes. On Windows, the default charset is typically Windows-1252, not UTF-8. This caused multi-byte UTF-8 characters like the ellipsis (…, U+2026) used by Status for line truncation to be decoded incorrectly, producing garbled output and failing the testStatusLineTruncation assertion.

The fix uses encoding() (inherited from AbstractTerminal) which returns the charset explicitly passed to the terminal constructor — StandardCharsets.UTF_8 in the tests.

Summary by CodeRabbit

• Bug Fixes
  • Corrected character encoding handling to use terminal's configured encoding rather than system defaults, improving compatibility with custom terminal configurations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 118d1668-7882-4227-828d-6eecd1ed629f

📥 Commits

Reviewing files that changed from the base of the PR and between 6561762 and e001751.

📒 Files selected for processing (1)

• terminal/src/test/java/org/jline/utils/DisplayTest.java

---

📝 Walkthrough

Walkthrough

The MasterOutputStream's CharsetDecoder initialization in the test file was updated to use the VirtualTerminal's configured encoding instead of the JVM's default charset. Error handling behavior remains unchanged.

Changes

Cohort / File(s)	Summary
CharsetDecoder Source Update terminal/src/test/java/org/jline/utils/DisplayTest.java	Changed CharsetDecoder initialization to use VirtualTerminal's configured encoding() instead of Charset.defaultCharset() for character decoding.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tiny tweak, so neat and small,
Terminal encoding rules them all!
From default charset we did part,
Now VirtualTerminal steals the heart.
One line changed, yet semantics shine! 🌟

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: switching from default charset to terminal encoding in VirtualTerminal, and references the related issue (#1821).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud