Node.SetProperty Only Allows String Properties

[brad-ross]

The function signature of Node.SetProperty is as follows:

func (e *Node) SetProperty(key string, value string) error

I would like my value to be a bool. Can you make the type of value be interface{}? You should be able to deal with non-string properties as you do when you pass a neoism.Props struct to Node.SetProperties...

[vsiv]

+1
I made the same comment earlier, as I have bool and array props

[vsiv]

@jmcvetta unfortunately changing the sig from string to interface{} will not be backward compatible. I can send a pull request, but to be backward compatible, i will have to add a new method - if u like that - whats a good name for the method for code convention...

[vsiv]

@brad-ross-35 in the meantime i just implemented the method myself - if u need here u go.. please note to test in ur env and production...

func SetNodeIfcProperty(n *neoism.Node, key string, value interface{}) error {
    parts := []string{n.HrefProperties, key}
    url := strings.Join(parts, "/")
        ne := neoism.NeoError{}
    resp, err := napping.Put(url, &value, nil, &ne)
    if resp == nil {
        // empty response
    } else if err != nil {
        return err
    } else if resp.Status() != 204 {
        return ne
    }
    return nil  // success
}

[brad-ross]

Thanks! I found a way around the problem, but hopefully there will be a patch soon--backwards compatibility shouldn't be a big issue, and I'm sure people using the library would rather account for the change than go on without being able to use non-string properties.

[jmcvetta]

Please feel free to submit a Pull Request with your suggested changes. Contributions are happily accepted!