Skip to content

chore: remove unneeded special case#54

Merged
cawalch merged 2 commits intojmespath-community:mainfrom
SamMousa:chore-remove-shortcut
May 24, 2025
Merged

chore: remove unneeded special case#54
cawalch merged 2 commits intojmespath-community:mainfrom
SamMousa:chore-remove-shortcut

Conversation

@SamMousa
Copy link
Copy Markdown
Contributor

@SamMousa SamMousa commented May 21, 2025

While working on the PHP implementation I noticed some unneeded code paths in the typescript implementation.

@springcomp springcomp requested a review from cawalch May 21, 2025 15:13
@springcomp
Copy link
Copy Markdown
Contributor

springcomp commented May 21, 2025

@SamMousa thank you for your contribution.

That is interesting. It seems to be path of code that will never trigger.
It seems we have the same code in both the Python and the Golang ports.

Other than that, it looks good to me.

@cawalch cawalch merged commit 88e0323 into jmespath-community:main May 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants