fix: texture stretching during resize#327
Open
Stumblinbear wants to merge 11 commits intojnschulze:mainfrom
Open
fix: texture stretching during resize#327Stumblinbear wants to merge 11 commits intojnschulze:mainfrom
Stumblinbear wants to merge 11 commits intojnschulze:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the issue of the texture being stretched when the
WebViewis resized. This PR results in the texture being cut off instead of stretching, which (while still not great) is a big improvement over the previous behavior.Recording.2026-03-04.174536.mp4
To resolve the issue, we call
texture_registrar_->MarkTextureFrameAvailable(texture_id_);when receivingsetSizeover the platform channel. This tells Flutter to callGetSurfaceDescriptor, which syncs the size of the texture on the next frame (oftentimes the current frame) instead of being delayed until WebView2 produces a frame.However, this still results in resizing the window being unusually heavy and a bit janky. To fix this, I set the frame pool to over-size itself by 25% so that rapid changes in the size (which typically occurs when resizing a window) doesn't result in dozens of intermediate textures being created and destroyed.
Lastly, I've created a render object to dispatch the
setSizecall during layout instead of waiting for a size change notification. This is admittedly a somewhat minor performance improvement, but does reduce the time it takes for the call to make it to the platform channelResolves #307