Skip to content

Some servers return cookies with 'Path' attribute instead of 'path' #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnunemaker merged 1 commit into from
Jan 30, 2013
Merged

Some servers return cookies with 'Path' attribute instead of 'path' #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/httparty/cookie_hash.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ def add_cookies(value)
end

def to_cookie_string
delete_if { |k, v| CLIENT_COOKIES.include?(k.to_s) }.collect { |k, v| "#{k}=#{v}" }.join("; ")
delete_if { |k, v| CLIENT_COOKIES.include?(k.to_s.downcase) }.collect { |k, v| "#{k}=#{v}" }.join("; ")
end
end
6 changes: 6 additions & 0 deletions spec/httparty/cookie_hash_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,11 @@
@s = @cookie_hash.to_cookie_string
@s.should_not match(/path=\//)
end

it "should not include client side only cookies even when attributes use camal case" do
@cookie_hash.add_cookies(:Path => "/")
@s = @cookie_hash.to_cookie_string
@s.should_not match(/Path=\//)
end
end
end