maintain blocks passed to 'perform' in redirects#191
Merged
jnunemaker merged 3 commits intojnunemaker:masterfrom Apr 10, 2013
Merged
maintain blocks passed to 'perform' in redirects#191jnunemaker merged 3 commits intojnunemaker:masterfrom
jnunemaker merged 3 commits intojnunemaker:masterfrom
Conversation
Owner
|
A regression test to confirm that this works is all the pull needs. Without one, I'm sure I'll break it down the road. |
…ntained for each redirect
Contributor
Author
|
Test added. Let me know if you need anything else. Thanks! Brian |
Contributor
Author
|
This also fixes another issue (fixed in 3f4a2db) where response.body was returning a Net::ReadAdapter. You can see this behavior by running: response = HTTParty.get("https://www.google.com/") { |chunk| }
response.bodyThe last line returns an empty Net::ReadAdapter rather than a string. This is due to calling read_body on the response if a block is present - and all subsequent calls to body will be Net::ReadAdapters rather than strings. |
jnunemaker
pushed a commit
that referenced
this pull request
Apr 10, 2013
maintain blocks passed to 'perform' in redirects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks passed to requests only get executed on the first HTTP request and don't get executed on future requests caused by a redirect.
For instance:
will only print out the lines for the 301 response, but will not be run for the following request.