Skip to content

Fix digest auth when multiple headers are sent by the server#272

Merged
jnunemaker merged 2 commits intojnunemaker:masterfrom
jsternberg:digest-auth-multiple-headers
Feb 14, 2014
Merged

Fix digest auth when multiple headers are sent by the server#272
jnunemaker merged 2 commits intojnunemaker:masterfrom
jsternberg:digest-auth-multiple-headers

Conversation

@jsternberg
Copy link
Contributor

Digest authentication would fail if more than one header was sent as
part of the response. Look specifically for the "Digest" word as part of
the www-authenticate header.

This fixes issue #271.

Digest authentication would fail if more than one header was sent as
part of the response. Look specifically for the "Digest" word as part of
the www-authenticate header.

This fixes issue #271.
@jnunemaker
Copy link
Owner

🆒 Could you add a spec to https://github.com/jnunemaker/httparty/blob/f7b84a97e9d08bf5e139121667b88385707426e2/spec/httparty/net_digest_auth_spec.rb to ensure we don't break this in the future? If so, happy to pull.

@jsternberg
Copy link
Contributor Author

@jnunemaker do you want me to do anything else before merging? Do you want me to squash the commits?

@jnunemaker
Copy link
Owner

jnunemaker pushed a commit that referenced this pull request Feb 14, 2014
Fix digest auth when multiple headers are sent by the server
@jnunemaker jnunemaker merged commit 2d66101 into jnunemaker:master Feb 14, 2014
@jsternberg
Copy link
Contributor Author

Cool! Thanks.

If I may ask, do you know when you're going to perform another release?

@jnunemaker
Copy link
Owner

Not sure, but you can lock to the specific sha in master. I typically do that. Avoids lots of tiny releases.

@jsternberg
Copy link
Contributor Author

OK. Do you think out would be possible to do another release? Gems can't lock onto a specific version and I have a gem that depends on this library that needs this patch. I can work around it in the final application with bundler, but it would be easier if I didn't have to.

@jnunemaker
Copy link
Owner

0.13.0 is out. Hopefully it causes no 🔥's. Lol.

@jsternberg
Copy link
Contributor Author

Thanks!

@jsternberg jsternberg deleted the digest-auth-multiple-headers branch February 14, 2014 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants