Allow empty array to be used as a params in get requests.

[dmitryrck]

Fixes #469

Now we have:

>> res = HTTParty.get('http://github.com', query: {fake_array: []})
# […]
>> res.request.last_uri.to_s
=> "https://github.com/?fake_array[]="

And:

>> res = HTTParty.get('http://github.com', query: {fake_array: [1]})
# […]
>> res.request.last_uri.to_s
=> "https://github.com/?fake_array[]=1"

Besides this fix I'd like to know what happens if you have something like this: HTTParty::Request.new(Net::HTTP::Get, 'http://google.com', query: { fake_array: [""] })

[jnunemaker]

Out of curiousity, what specifically made it so you need this?

[dmitryrck]

Well… I was doing baby steps and the change was required, but I double-checked and it is not required anymore :)

[jnunemaker]

I checked locally and this isn't needed to make any specs pass. Do we need a new spec or is this extra as well?

[dmitryrck]

Weird… I remember I needed this :/

Let me check :)

[dmitryrck]

Hey @jnunemaker thank you for the great review, it was necessary to change only HTTParty::HashConversions eventually :)

[DaftTrick]

In this PR you mention that change of behavior should be only for get method.
But this PR also changed working with POST request also. Is that designed that way or just a side-bug?

[dmitryrck]

@DaftTrick I did all the tests based on GET, but I did not remember of seeing anything to mean that the behavior should be only to GET, so I think this code should work to POST too.

Why? Any problem with that?

P. S.: Sorry by the delay :)