Add status predicate methods to Response#respond_to?#482
Merged
jnunemaker merged 1 commit intojnunemaker:masterfrom Jun 24, 2016
Merged
Add status predicate methods to Response#respond_to?#482jnunemaker merged 1 commit intojnunemaker:masterfrom
jnunemaker merged 1 commit intojnunemaker:masterfrom
Conversation
Expands the existing respond_to? first-party method list to include the HTTP status predicates. Useful for things like rspec, which check respond_to? when using predicate matchers.
|
|
||
| it "responds to predicates" do | ||
| response = HTTParty::Response.new(@request_object, @response_object, @parsed_response) | ||
| expect(response.respond_to?(:success?)).to be_truthy |
Owner
There was a problem hiding this comment.
Kind of concerned that we'll unknowingly break compatibility since only success? is tested, but I guess we can roll and see what happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands the existing
respond_to?first-party method list to include the HTTP status predicates. Useful for things like RSpec, which checkrespond_to?when using predicate matchers - beyond that it makes for a more consistent and predictable object (If I can call it, it shouldrespond_to?).Because
Responseinherits fromBasicObjectwe miss out on quite a few of these pre-made tools fromObject, though it looked like moving away fromBasicObjectwas a bigger task and would require a bit more debate. I figured this was the simplest change to make.I have not checked for other methods that could be added to
RESPOND_TO_METHODS, my concern was with the predicate methods.