Fix multipart filename for ActionDispatch::Http::UploadedFile TempFile

[zherr]

Closes #597

[zherr]

I'll CC @TheSmartnik here as they seem active in reviewing PRs as of late. I would greatly appreciate your input!

[TheSmartnik]

Hi @zherr ,
I don't know how qualified I'm to review your pr here, but it looks great, thanks!
RestClient solves the problem the same way for 9 years (should've looked at it when implemented the feature 😩), already. So I think we are good.

The only thing that bothers me is expose_dsl_globally. It looks very much unnecessary here.

[zherr]

Thanks for taking a look @TheSmartnik.

As for expose_dsl_globally, this is purely a testing configuration for rspec, and won’t have any affect outside of running tests. Docs can be seen here: https://relishapp.com/rspec/rspec-core/v/3-8/docs/configuration/global-namespace-dsl

I’m hoping this one could get merged and released. @jnunemaker , when you have a few minutes, would you reviewing this one?

[TheSmartnik]

@zherr thanks for the link!
What I don't like about expose_dsl_globally is that we are changing default behavior without any requirement or reason.

What problems will it bring? It may lead to inconsistent style of specs.
Some will start with Rspec.describe some with describe. You yourself changed only two files, while number of specs is much greater.

Why consistency is important? It saves you from thinking about unneeded things. Imagine a newcomer that codes in ruby for a couple of years and doesn't know RSpec 2 syntax. He'll start to write a spec, but some start with Rspec.describe, others with describe. How should he start? Why some are different that the others? All those questions and no good answer for them. Instead he could spend time actually writing code.

[zherr]

@TheSmartnik check out the latest commit: 30d9036

I've made the use of the RSpec DSL consistent, to avoid the possible confusion as you outlined.