feat: add container match pattern (regex)#82
Open
lad1337 wants to merge 1 commit intojohanhaleby:masterfrom
Open
feat: add container match pattern (regex)#82lad1337 wants to merge 1 commit intojohanhaleby:masterfrom
lad1337 wants to merge 1 commit intojohanhaleby:masterfrom
Conversation
Owner
|
Hi! Thanks for the PR! What happens when you specify both a normal container name (1) and a container pattern (2)? From what I understand it first tries to match on (1) and only those that matches (1) are eligible for (2)? Is this correct? Should this really be the case? Perhaps it's easier to understand, and it's more consistent with how pod matching works, if it's strictly either (1) or (2)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are using some auto injected containers into our pods (linkerd) and i still want to be able to follow multiple pods that have different containers i added a container name filter option.
example
-Cis short for--container-patternwhich defaults to.*note: i'm not sure how to format the help text with the long name
container-pattern