fix: Add missing type annotation and remove redundant default case - …#3427
Open
abhaysaqi wants to merge 1 commit intojonataslaw:masterfrom
Open
fix: Add missing type annotation and remove redundant default case - …#3427abhaysaqi wants to merge 1 commit intojonataslaw:masterfrom
abhaysaqi wants to merge 1 commit intojonataslaw:masterfrom
Conversation
…Added 'bool' return type to _canPop() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TITLE FIELD:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
fix: Add missing type annotation to _canPop method
DESCRIPTION FIELD:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Description
Fixed Dart analyzer warning by adding missing type annotation to
_canPop()method and removing redundant default case.
Changes
boolreturn type to_canPop()methoddefaultcase in switch statement (enum exhaustiveness)File:
lib/get_navigation/src/routes/get_router_delegate.dartTesting
dart analyze— No issuesType of Change